Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor initial CMAKE_Fortran_FLAGS/FFLAGS #700

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

opoplawski
Copy link
Contributor

We need to be able to specify extra Fortran flags.

@jenkins-cscs
Copy link
Collaborator

Can one of the admins verify this patch?

@dev-zero
Copy link
Contributor

dev-zero commented Sep 8, 2023

@opoplawski ACK, but can you please add this change to the other compiler sections as well?

@dev-zero
Copy link
Contributor

dev-zero commented Sep 8, 2023

Please note that you can always define your own CMake build type as described in the DBCSR manual to add custom flags. But I see why it may be annoying if DBCSR ignores FFLAGS completely while all other packages usually take those into account.

@opoplawski
Copy link
Contributor Author

All compilers updated. Thanks.

@hfp hfp merged commit c2079f0 into cp2k:develop Sep 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants